Inline generic_matmatmul! branch in strided triangular matmul
#1262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1262 +/- ##
=======================================
Coverage 92.00% 92.00%
=======================================
Files 34 34
Lines 15483 15485 +2
=======================================
+ Hits 14245 14247 +2
Misses 1238 1238 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jishnub
force-pushed
the
jishnub/trimatmul_generic
branch
from
53586e2 to
331d7e2
Compare
Member
Author
|
Gentle bump |
dkarrasch
approved these changes
Apr 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For combinations of strided matrices and strided triangular matrices, we would end up taking the methods defined in
LinearAlgebra, so we may avoid the constant-propagation and hardcode the_generic_matmatmul!call. This improves TTFX, as the no-op but expensive-to-compilewrapcall is elided.